badoo / badoo/Chatto

iPhone X, photo picker image should have safe area inset

Open
#377 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
4.6k
Forks
588
PR merge metrics
No merged PRs in 30d

Description

screen shot 2017-10-18 at 12 55 53

As you see this photo picker button is near bottom, but it should be binded into safe area, so have 32 points more from bottom on iPhone X.

Possibly it's not Chatto issue, please investigate it. @AntonPalich

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the photo picker on an iPhone X and trace the photo picker button's layout entry point. Confirm whether the issue belongs to Chatto, then adjust the bottom positioning so the button respects the safe-area inset; done means it has the requested spacing without affecting other devices.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.