badges / badges/shields

Add rating out of 5 render helpers and test validators

Open
#4,902 2 comments 1 reaction 0 assignees View on GitHub
developer-experience
Dominant language
JavaScript
Stars
27.2k
Forks
5.6k
Avg merge
1d 8h
Merged PRs (30d)
46

Description

:clipboard: **Description**

Add validators for
- integer rating out of 5
- float rating out of 5

to `test-validators` and use them consistently in rating badge service tests

Refs https://github.com/badges/shields/pull/4898#discussion_r407105049

Contributor guide

Open the contributing guide

Research direction

Start by locating the test-validators helpers and the rating badge service tests. Check how existing integer and float rating validators are structured, then add the out-of-5 cases and use them consistently in the rating badge service tests. Done means both rating forms are covered and the affected test suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.