badges / badges/shields

Bring serviceData and makeBadge schemas into full alignment

Open
#3,370 0 comments 1 reaction 0 assignees View on GitHub
core npm-package
Dominant language
JavaScript
Stars
27.2k
Forks
5.6k
Avg merge
1d 8h
Merged PRs (30d)
46

Description

Since #2863 is done, the schema translation being performed in `coalesceBadge()` is no longer useful. If we bring the `makeBadge()` schema into full alignment with `serviceData`, we won't need to translate schema in `coalesceBadge()`.

The function would still exist, but it would only coalesce, not _also_ translate schema.

This is dependent on resolving named icons within `makeBadge()` and making simple-icons an optional dependency.

This work is related to #3369, though separable.

Contributor guide

Open the contributing guide

Research direction

Start by reading makeBadge() and coalesceBadge(), then compare the makeBadge() schema with serviceData and review the work described in #2863 and #3369. Done means named icons are resolved within makeBadge(), simple-icons is optional, and coalesceBadge() only coalesces without translating the schema.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.