badges / badges/shields

Rewrite high-level color override tests in core

Open
#3,068 1 comment 0 reactions 0 assignees View on GitHub
core
Dominant language
JavaScript
Stars
27.2k
Forks
5.6k
Avg merge
1d 8h
Merged PRs (30d)
46

Description

The dynamic JSON, XML, and YAML services have service tests for color override functionality which is in BaseService. The low-level functionality is checked in `coalesceBadge` which is fine, though there probably should be a higher-level test for BaseService.

These tests should be removed from `dynamic-*.tester.js`.

Ref: https://github.com/badges/shields/pull/3066#discussion_r258731711

Contributor guide

Open the contributing guide

Research direction

Start with the color override tests in dynamic-*.tester.js and compare them with the low-level coalesceBadge coverage. Read BaseService to determine the appropriate higher-level test location, then remove the duplicated service tests and ensure the remaining coverage still verifies the intended color override behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.