static badge bypasses globalQueryParams
- Dominant language
- JavaScript
- Stars
- 27.2k
- Forks
- 5.6k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 46
Description
Refs
- https://github.com/badges/shields/pull/9191
- https://github.com/badges/shields/pull/10110
In #9191 we accidentally added a global query param which only worked on the static badge.
This implies that when we parse the query params on that badge, we are bypassing `globalQueryParams`.
My guess is this probably represents oversight rather than intent, but I need to dig into it.
Contributor guide
Research direction
Compare the static badge query-parameter parsing with globalQueryParams, using pull requests #9191 and #10110 as context. Trace where the static badge handles these parameters and determine whether the behavior is intentional. Done means the intended global query-parameter behavior is established and covered by an appropriate regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100