backstage / backstage/backstage
Snyk vulnerability [SNYK-JS-BACKSTAGEPLUGINTECHDOCSNODE-15166605]
- Dominant language
- TypeScript
- Stars
- 34.4k
- Forks
- 7.6k
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 211
Description
## Affecting Packages/Plugins
* [example-backend](packages/backend/package.json)
* [@techdocs/cli](packages/techdocs-cli/package.json)
* [@backstage/plugin-search-backend-module-techdocs](plugins/search-backend-module-techdocs/package.json)
* [@backstage/plugin-techdocs-backend](plugins/techdocs-backend/package.json)
## Overview
[@backstage/plugin-techdocs-node](https://www.npmjs.org/package/@backstage/plugin-techdocs-node) is a Common node.js functionalities for TechDocs, to be shared between techdocs-backend plugin and techdocs-cli
Affected versions of this package are vulnerable to Directory Traversal via the `TechdocsGenerator` function when processing documentation from untrusted sources. An attacker can access sensitive files outside the intended directory by submitting symlinks within the docs, resulting in file contents being embedded into generated HTML and exposed to users who can view the documentation.
## Workaround
Switch to `runIn: docker` in your `app-config.yaml`
## Details
A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.
Directory Traversal vulnerabilities can be generally divided into two types:
- **Information Disclosure**: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.
`st` is a module for serving static files on web pages, and contains a [vulnerability of this type](https://snyk.io/vuln/npm:st:20140206). In our example, we will serve files from the `public` route.
If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.
```
curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa
```
**Note** `%2e` is the URL encoded version of `.` (dot).
- **Writing arbitrary files**: Allows the attacker to create or replace existing files. This type of vulnerability is also known as `Zip-Slip`.
One way to achieve this is by using a malicious `zip` archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.
The following is an example of a `zip` archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in `/root/.ssh/` overwriting the `authorized_keys` file:
```
2018-04-15 22:04:29 ..... 19 19 good.txt
2018-04-15 22:04:42 ..... 20 20 ../../../../../../root/.ssh/authorized_keys
```
## Remediation
Upgrade `@backstage/plugin-techdocs-node` to version 1.13.11, 1.14.1 or higher.
## References
- [GitHub Commit](https://github.com/backstage/backstage/commit/3c455d41516d70ba952192b12627f2a32b7387cb)
- [Red Hat Bugzilla Bug](https://bugzilla.redhat.com/show_bug.cgi?id=2435575)
Contributor guide
Research direction
Inspect the four package.json files named in the report and trace how @backstage/plugin-techdocs-node is declared. Upgrade it to 1.13.11, 1.14.1, or higher, then confirm the affected packages resolve a remediated version and the vulnerability is no longer reported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, typescript
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100