bSI-InfraRoom / bSI-InfraRoom/IFC-Specification

`IfcSweptDiskSolidPolygonal` changed to `IfcNonNegativeLengthMeausure`

Open
#830 0 comments 0 reactions 4 assignees Claimed by @anborr View on GitHub
EXPRESS
Dominant language
No language data
Stars
27
Forks
24
PR merge metrics
No merged PRs in 30d

Description

@aothms @TLiebich It seems to me that the `IfcSweptDiskSolidPolygonal` was just changed to `IfcNonNegativeLengthMeausure` and the documentation has not changed. Must have been submitted to ISO like that then.

> It's a unification

On this I would have expected the unification to go the other way around honestly. From a more common entity to the one that is less used.

Are there plans on changing the documentation? I was waiting with this PR for that but now I would have to merge for Tunnel Deployment to have a solid baseline.

EDIT: Just remembered that the where rule and 0 filet radius do not fit well together either.

_Originally posted by @SergejMuhic in https://github.com/bSI-InfraRoom/IFC-Specification/issues/467#issuecomment-1424632305_

The WR does not make sense for `FilletRadius`=0. The documentation was not updated according to the agreement either.

Also, pinging @aothms all of the renamed attributes are desynched so they did not get documentation from the markdown.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.