bSI-InfraRoom / bSI-InfraRoom/IFC-Specification

RC4_Update pset issues

Open
#326 5 comments 1 reaction 6 assignees Claimed by @AlexBrad1eyCT View on GitHub
properties quantities
Dominant language
No language data
Stars
27
Forks
24
PR merge metrics
No merged PRs in 30d

Description

When going over the RC4_Update psets I found the following issues:

1. No SingleValue DataType: Pset_CivilElementCommon.Reference
2. No SingleValue DataType: Pset_ElementAssemblyCommon.Reference
3. No SingleValue DataType: Pset_FurnitureTypeCommon.Reference
4. No SingleValue DataType: Pset_RampCommon.LoadBearing
5. No SingleValue DataType: Pset_RampCommon.ThermalTransmittance
6. No SingleValue DataType: Pset_RoadMarkingCommon.MaterialColour
7. No SingleValue DataType: Pset_RoofCommon.LoadBearing
8. No SingleValue DataType: Pset_SpatialZoneCommon.Reference
9. No SingleValue DataType: Pset_StairCommon.LoadBearing
10. No SingleValue DataType: Pset_StairCommon.ThermalTransmittance
11. No templatetype: Pset_BoreholeCommon
12. No templatetype: Pset_BridgeCommon
13. No templatetype: Pset_CivilElementCommon
14. No templatetype: Pset_ElementAssemblyCommon
15. No templatetype: Pset_GeotechnicalAssemblyCommon
16. No templatetype: Pset_GeotechnicalStratumCommon
17. No templatetype: Pset_LinearReferencingMethod
18. No templatetype: Pset_MaintenanceStrategy
19. No templatetype: Pset_MarineFacilityTransportation
20. No templatetype: Pset_MarkingLinesCommon
21. No templatetype: Pset_MobileTelecommunicationsApplianceTypeCommon
22. No templatetype: Pset_PavementCommon
23. No templatetype: Pset_PlantCommon
24. No templatetype: Pset_ReferentCommon
25. No templatetype: Pset_RoadGuardElement
26. No templatetype: Pset_RoadMarkingCommon
27. No templatetype: Pset_RoadSymbolsCommon
28. No templatetype: Pset_SensorTypeFrostSensor
29. No templatetype: Pset_SensorTypeIdentifierSensor
30. No templatetype: Pset_SolidStratumCapacity
31. No templatetype: Pset_SolidStratumComposition
32. No templatetype: Pset_SpatialZoneCommon
33. No templatetype: Pset_Stationing
34. No templatetype: Pset_SumpBusterCommon
35. No templatetype: Pset_TrafficCalmingDeviceCommon
36. No templatetype: Pset_Uncertainty
37. No templatetype: Pset_WaterStratumCommon
38. Templatetype QTO_TYPEDRIVENOVERRIDE: Pset_MarineVehicleCommon

So 3 categories of issues:

* Missing underlying type for TypePropertySingleValue

Most of these I can figure out myself in the migration. LoadBearing is obviously a bool. A bit surpised perhaps to see Pset_(Stair|Ramp)Common.LoadBearing and Pset_RampCommon.ThermalTransmittancebut but those are not 4x3 issues I suppose.

Should MaterialColour be a reference property to a IfcColourRGB instead?

* Missing template type (PSET_OCCURRENCEDRIVEN, PSET_PERFORMANCEDRIVEN, PSET_TYPEDRIVENOVERRIDE)

If we can agree on some default (maybe there already is, I don't know) then it's not an issue I assume, unless you feel like these psets should deviate from that default

* Pset_MarineVehicleCommon has a template type of QTO_TYPEDRIVENOVERRIDE, I doubt that can be correct, but perhaps it is?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.