azu / azu/get-github-pr-review-comments

Using token in the url as a get parameter is deprecated

Open
#8 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
17
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Hi

I used the tool today and it works perfectly. However, right after I received an email from Github:

> On January 26th, 2021 at 15:52 (UTC) your personal access token (All access) using NodeJS HTTP Client was used as part of a query parameter to access an endpoint through the GitHub API:
>
> https://api.github.com/search/issues
>
> Please use the Authorization HTTP header instead, as using the `access_token` query parameter is deprecated. If this token is being used by an app you don't have control over, be aware that it may stop working as a result of this deprecation.
>
> Depending on your API usage, we'll be sending you this email reminder on a monthly basis for each token and User-Agent used in API calls made on your behalf.
> Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.
>
>Visit https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param for more information about suggested workarounds and removal dates.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the GitHub API request for the search/issues endpoint and inspect how the token is passed. Change the request to follow GitHub's Authorization HTTP header guidance, then verify that the CLI still retrieves pull-request review comments without using a query parameter.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, javascript, node.js
Domain
api, cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.