azerothcore / azerothcore/mod-progression-system
[TBC bracket, PVP] - Re-introduction of Uniqueness vs. unification of Crit value for Gems
- Dominant language
- C++
- Stars
- 82
- Forks
- 68
- Avg merge
- 59m
- Merged PRs (30d)
- 10
Description
CC Issue: https://github.com/chromiecraft/chromiecraft/issues/5717
### What client do you play on?
enUS
### Faction
Both
### Content Phase:
70
### Current Behaviour
The Epic PvP Gems are going to become accessible with the re-added limitation of them being unique.
Back in TBC 2 separate gems existed for melee crit chance and spell crit chance.
In wotlk, these stats are merged into 1 crit value affecting both melee and spell crit.
Given that the uniqueness of these gems has been re-introduced, primarily to prevent early, unlimited access to attackpower and spellpower gems, we will have access to 2 crit gems instead of 1 per damage type.
### Expected Blizzlike Behaviour
To properly progress through the availability and given content in tbc but on a wrath client
A) the gems should be reverted to affect melee or spell crit respectively only
B) (likely easier) make 1 of 2 gems not available
### Source
https://www.wowhead.com/wotlk/search?q=ornate+dawnstone
https://www.wowhead.com/tbc/search?q=ornate+dawnstone
### Steps to reproduce the problem
.
### Extra Notes
_No response_
### AC rev. hash/commit
https://github.com/chromiecraft/azerothcore-wotlk/commit/5c31998573613c7564d4d5a9b050d2656b0e4c23
### Operating system
Ubuntu 20.04
### Modules
- [mod-ah-bot](https://github.com/azerothcore/mod-ah-bot)
- [mod-bg-item-reward](https://github.com/azerothcore/mod-bg-item-reward)
- [mod-BreakingNewsOverride](https://github.com/AnchyDev/BreakingNewsOverride)
- [mod-cfbg](https://github.com/azerothcore/mod-cfbg)
- [mod-chat-transmitter](https://github.com/azerothcore/mod-chat-transmitter)
- [mod-cta-switch](https://github.com/azerothcore/mod-cta-switch)
- [mod-desertion-warnings](https://github.com/azerothcore/mod-desertion-warnings)
- [mod-duel-reset](https://github.com/azerothcore/mod-duel-reset)
- [mod-eluna](https://github.com/azerothcore/mod-eluna)
- [mod-instanced-worldbosses](https://github.com/nyeriah/mod-instanced-worldbosses)
- [mod-ip-tracker](https://github.com/azerothcore/mod-ip-tracker)
- [mod-low-level-arena](https://github.com/azerothcore/mod-low-level-arena)
- [mod-low-level-rbg](https://github.com/azerothcore/mod-low-level-rbg)
- [mod-multi-client-check](https://github.com/azerothcore/mod-multi-client-check)
- [mod-progression-system](https://github.com/azerothcore/mod-progression-system)
- [mod-pvp-titles](https://github.com/azerothcore/mod-pvp-titles)
- [mod-pvpstats-announcer](https://github.com/azerothcore/mod-pvpstats-announcer)
- [mod-queue-list-cache](https://github.com/azerothcore/mod-queue-list-cache)
- [mod-rdf-expansion](https://github.com/azerothcore/mod-rdf-expansion)
- [mod-transmog](https://github.com/azerothcore/mod-transmog)
- [mod-weekend-xp](https://github.com/azerothcore/mod-weekend-xp)
- [mod-zone-difficulty](https://github.com/azerothcore/mod-zone-difficulty)
- [lua-carbon-copy](https://github.com/55Honey/Acore_CarbonCopy)
- [lua-event-scripts](https://github.com/55Honey/Acore_eventScripts)
- [lua-exchange-npc](https://github.com/55Honey/Acore_ExchangeNpc)
- [lua-level-up-reward](https://github.com/55Honey/Acore_LevelUpReward)
- [lua-recruit-a-friend](https://github.com/55Honey/Acore_RecruitAFriend)
- [lua-send-and-bind](https://github.com/55Honey/Acore_SendAndBind)
- [lua-temp-announcements](https://github.com/55Honey/Acore_TempAnnouncements)
- [lua-zonecheck](https://github.com/55Honey/acore_Zonecheck)
### Customizations
None
### Server
ChromieCraft
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by comparing the TBC and Wrath Wowhead results linked in the issue, then inspect how the progression module defines the listed Epic PvP gems and their uniqueness. Done means applying one decided behavior—separate melee and spell crit effects, or removing one gem—and verifying the available gems match the intended TBC progression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100