azerothcore / azerothcore/mod-guild-zone-system
Cost of a 1k gold does not work
- Dominant language
- C++
- Stars
- 12
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
if a guildmaster is going to buy the house even though he doesn't have the required money (1k gold) it is sold, since the only thing the module does is modify the money (player->ModifyMoney(-10000000);) and it doesn't check the existing amount of the player.
There is also the possibility of a bug with the increase in money, I buy the area with 0 money and sell it for 500 gold, I trade it to another pj and do the same operation.
The ideal would be to check the existing money in the bank of the brotherhood if it is equal to 1k buy, and when selling the same as the money, go to the bank of the brotherhood
@acidmanifesto
Contributor guide
No contributing guide indexed for this repository
Research direction
No file or test is named. Start by locating the guild-house purchase and sale paths around player->ModifyMoney(-10000000), then trace how guild-bank funds are represented and checked. Done means insufficient funds prevent purchases, sale proceeds reach the guild bank, and repeated buy/sell/trade operations cannot create money.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100