azerothcore / azerothcore/mod-autobalance

Bug: High HP scaling in worldserver.conf with Enable.Global off causes sporadic or no rewards in dungeons

Open
#215 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
160
Forks
141
PR merge metrics
No merged PRs in 30d

Description

### Current Behaviour

Having high HP scaling values in worldserver.conf while mod-autobalance is included in the build AND AutoBalance.Enable.Global=0 causes enemies to not trigger the "rewards" on death, i.e. xp, loot, achievements etc.

Tested with parameters, worldserver.conf:
Rate.Creature.Normal.HP = 2.5
Rate.Creature.Elite.Elite.HP = 2.5
Rate.Creature.Elite.RARE.HP = 4
Rate.Creature.Elite.RAREELITE.HP = 4
Rate.Creature.Elite.WORLDBOSS.HP = 1.5

Autobalance.conf :
AutoBalance.Enable.Global=0

### Expected Behaviour

Rewards should be given regardless of the default scaling parameters.
AutoBalance.Enable.Global=0 should be respected and turn of any scaling activities from this module.

### Steps to reproduce the problem

Build with AzerothCore + mod-autobalance.

Set in worldserver.conf:
Rate.Creature.Normal.HP = 2.5
Rate.Creature.Elite.Elite.HP = 2.5
Rate.Creature.Elite.RARE.HP = 4
Rate.Creature.Elite.RAREELITE.HP = 4
Rate.Creature.Elite.WORLDBOSS.HP = 1.5

Set in AutoBalance.conf:
AutoBalance.Enable.Global=0

start killing enemies/bosses in dungeons.

### Extra Notes

Noted on a whim when experimenting with server rates.

An assumption of the issue _could_ be related to the killReward requirements.
Something creates a situation where it is impossible to satisfy the damage requirement for example.

### AutoBalance Debug Commands

_No response_

### AC rev. hash/commit

https://github.com/azerothcore/azerothcore-wotlk/commit/9320f9e1e6df5456670efaf6abae87c990486b39

### Operating system

Win 11

### Custom changes or Modules

No other when doing isolated tests

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the issue with the listed worldserver.conf HP rates and AutoBalance.Enable.Global=0, then trace the module's killReward requirements and reward handling. Done means dungeon enemies and bosses consistently grant XP, loot, and achievements while global AutoBalance remains disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.