azerothcore / azerothcore/Keira3

[Enchantement] - Improvements to SAI Comment (Auto-Generate)

Open
#3,255 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
450
Forks
183
Avg merge
23h 42m
Merged PRs (30d)
18

Description

Probably we could implement something similiar to wowgaming.

Going to use Razormanes are examples.

https://wowgaming.altervista.org/aowow/?npc=3266 and https://wowgaming.altervista.org/aowow/?npc=3269

Example:
| id | comment |
| --- | --- |
| 0 | Razormane Defender - On aggro - Casts `Battle Stance` (self, once, 100% of the time)
| 1 | Razormane Defender - In Combat (after 35 seconds) - Casts `Demoralising Shout` (current target, every 10 seconds, 60%) |
| 2 | Razormane Defender - In Combat (after 11.5 seconds) - Casts `Heroic Strike` (current targert, every 4 seconds, 100%) |

Explanation:
(0) instead of no repeat from wowgaming, no repeat = once). dont know if % should ahve "of the time" after.

(1 and 2) dont know where better to place thte 35 seconds (after starting combat) and convert seconds to minutes or hours or days depending on their value. 60 seconds should say 1 minute.

Currently (not at pc so no access to keira)
| id | comment |
| --- | --- |
| 0 | Razormane Defender - On aggro - Casts `Battle Stance` (i think it says no repeat)
| 1 | Razormane Defender - In Combat - Casts `Demoralising Shout`
| 2 | Razormane Defender - In Combat - Casts `Heroic Strike`

Does it clutter the comment section of the unit? Yes and no, since is informative information. First example we can see straight away that razormane defender casts in combat will cast demoralsing shout at the victim every 10 seconds with a 60% chance of casting after 35 in combat

Contributor guide

No contributing guide indexed for this repository

Research direction

No file or test is named in the issue. Start at Keira's SAI Comment (Auto-Generate) entry point and compare the linked Razormane examples; done means the generated comments consistently express the trigger, delay, repeat interval, chance, and target as agreed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
databases, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.