azerothcore / azerothcore/Keira3

[Loot Editor] Keira can't handle same item IDs in different rows

Open
#2,242 2 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
450
Forks
183
Avg merge
23h 42m
Merged PRs (30d)
18

Description

![image](https://user-images.githubusercontent.com/100873791/227786621-a1c43d14-261d-40b4-8ff4-b6702410c397.png)

Only the first row is modified.

1. Apply https://github.com/azerothcore/azerothcore-wotlk/pull/15574
2. Edit creature entry 19220

GroupID was made a primary key here: https://github.com/azerothcore/azerothcore-wotlk/pull/9379

---
Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/118563775-loot-editor-keira-can-t-handle-same-item-ids-in-different-rows?utm_campaign=plugin&utm_content=tracker%2F139701226&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F139701226&utm_medium=issues&utm_source=github).

Contributor guide

No contributing guide indexed for this repository

Research direction

Apply azerothcore/azerothcore-wotlk#15574 and reproduce the issue by editing creature entry 19220 in the Loot Editor. Read the context of GroupID becoming a primary key in PR #9379, then trace how rows with the same item ID are selected or modified. Done means editing one row no longer changes only the first matching row.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
database, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.