azavea / azavea/python-omgeo

Default postprocessors on EsriWGS are too strict.

Open
#19 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
37
Forks
14
PR merge metrics
No merged PRs in 30d

Description

Be default, if doing a gazetteer style search, the defautl postprocessors filter out everything.

To test:

Set up and run a new geocoder with EsriWSG:

``` python
pq = PlaceQuery(query='the white house', country='US')
result = geocoder.geocode(pq)
```

You should get a few responses from the raw response:

``` python
[, ]
```

But they get filtered out in /services/base.py

``` python
except Exception as e:
upstream_response_info.set_success(False)
upstream_response_info.errors.append(format_exc())
return [], upstream_response_info
if len(candidates) > 0:
for p in self._postprocessors: # apply universal candidate postprocessing
candidates = p.process(candidates) # merge lists
return candidates, upstream_response_info
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.