aymara / aymara/lima

Deeplima dp train: The list of expected tasks should not be hard-coded

Open
#156 0 comments 0 reactions 1 assignee Claimed by @victorbocharov View on GitHub
bug confirmed crash
Dominant language
C++
Stars
119
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Currently the list of tasks the parser training model expects from the tagging model (form,upos…) is hard-coded while the tagging model can be trained with various tasks.
This list should be saved somewhere and retrieved.

This is described here: https://github.com/aymara/lima/blob/7c7b1c68f4fce280e9db1aadf69a7829aacd2e0b/deeplima/libs/tasks/graph_dp/train/train_graph_dp.cpp#L77

And in 7c7b1c68f4fce280e9db1aadf69a7829aacd2e0b

If tasks lists does not match, parsing fails with
```
terminate called after throwing an instance of 'std::logic_error'
what(): Input classes missmatch: xpos != Definite
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.