axodotdev / axodotdev/oranda

mdbook: move font decls to variable files

Open
#383 0 comments 0 reactions 0 assignees View on GitHub
feature - themes
Dominant language
Rust
Stars
543
Forks
34
PR merge metrics
No merged PRs in 30d

Description

Currently we overload mdbook's fonts.css file to declare all the `@fontfaces` all of our themes could want, but we don't vary the fonts by theme.

We should either:

* not override this file, and instead place fontface decls in the variable files that want them (axo.css, cupcake.css, ...)
* template this file and write the fontface decls in dynamically

I'm more inclined to the first option, as it keeps more things in one place.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading fonts.css and the theme variable files named in the issue, including axo.css and cupcake.css. Compare where the current @font-face declarations are defined and determine whether the preferred per-theme approach fits the existing structure. Done means themes no longer share font declarations they do not use, with the selected approach applied consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
design, frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.