axodotdev / axodotdev/harbor

distinguish between the Goal and the Solution/Recommendation

Open
#14 1 comment 0 reactions 1 assignee Claimed by @Gankra View on GitHub
enhancement webapp-ui
Dominant language
JavaScript
Stars
3
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Currently the UI frames the Solutions/Recommendations as if they are Goals (or the updates that actually happened to your dependencies). In reality they are just "the easiest fix" and may be fairly disjointed from the goal, especially with imported audit files.

The "failures" array in the Report (which we currently ignore) contains the "goals". **I have some local experimental changes to merge that info in and tweak the UI.**

For instance you may have a situation like:

* failure: need audit for 3.0 (say you just update to that version)

And your audits/imports look like:

* review for 1.0 (yours)
* review for 2.0 -> 3.0 (imported from mozilla who has an exemption for 2.0)

cargo-vet will likely end up recommending 1.0->2.0 as a way to *achieve* an audit for 3.0. The goal and the solution are quite disjointed (and there's basically no relation to what actually changed in your dependencies, which not even cargo-vet knows)!

(I dream of cargo-vet emitting graphs to explain this stuff but that's way out of scope).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.