axodotdev / axodotdev/cargo-dist

investigate powershell installer un-variabling PATH entries

Open
#933 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
2.1k
Forks
149
Avg merge
1d 11h
Merged PRs (30d)
32

Description

In the powershell installer we load, edit, and save the registry value storing (part of) the user's PATH. In testing in CI I noticed that the value of `$env:UserProfile` (one of the windows equivs of `$HOME`) in the current env was appearing in the result. This suggest to me that the values in ci were like `%USERPROFILE%/.cargo/bin` and in the process of reading/editing we forced those to get substituted permanently, degrading their quality.

We should:

* not be substituting existing values
* ideally be writing %USERPROFILE% values ourselves when appropriate (as the shell installer does)

Contributor guide

Open the contributing guide

Research direction

Start with the PowerShell installer code that reads and writes the registry-backed PATH value, then reproduce the CI case involving %USERPROFILE%/.cargo/bin. Done means existing PATH placeholders remain unexpanded and appropriate new entries use %USERPROFILE% where applicable, with CI validation covering the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.