axodotdev / axodotdev/cargo-dist

CI: `host` job doesn't depend on success of custom build jobs

Open
#919 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
2.1k
Forks
149
Avg merge
1d 11h
Merged PRs (30d)
32

Description

It's not clear if this is intentional behaviour or not, but the condition for the `host` GitHub Actions job does not depend on the outcome of any custom build jobs:

https://github.com/axodotdev/cargo-dist/blob/5e7826f7b09a64e5ba9edc16dab8cee7b13daa27/cargo-dist/templates/ci/github_ci.yml.j2#L392-L394

Contributor guide

Open the contributing guide

Research direction

Start with cargo-dist/templates/ci/github_ci.yml.j2 at lines 392-394 and inspect how the host job condition relates to custom build jobs. Confirm whether host should wait for and reflect those jobs' outcomes; done means the dependency behavior is intentional or corrected and the generated GitHub Actions workflow validates it.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, rust
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.