axodotdev / axodotdev/cargo-dist
v1.0 release candidates generate wrong link in release.yml
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.1k
- Forks
- 150
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 32
Description
I have updated to
and run cargo dist init to refresh release.yml.
I see it has:
```
- name: Install dist
# we specify bash to get pipefail; it guards against the `curl` command
# failing. otherwise `sh` won't catch that `curl` returned non-0
shell: bash
run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/axodotdev/cargo-dist/releases/download/v1.0.0-rc.1/cargo-dist-installer.sh | sh"
```
My builds now fail thus: https://github.com/andrewdavidmackenzie/pigg/actions/runs/13285076882/job/37091880185?pr=857
```
Run curl --proto '=https' --tlsv1.2 -LsSf https://github.com/axodotdev/cargo-dist/releases/download/v1.0.0-rc.1/cargo-dist-installer.sh | sh
curl --proto '=https' --tlsv1.[2](https://github.com/andrewdavidmackenzie/pigg/actions/runs/13285076882/job/37091880185?pr=857#step:3:2) -LsSf https://github.com/axodotdev/cargo-dist/releases/download/v1.0.0-rc.1/cargo-dist-installer.sh | sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
GH_TOKEN: ***
curl: (22) The requested URL returned error: [4](https://github.com/andrewdavidmackenzie/pigg/actions/runs/13285076882/job/37091880185?pr=857#step:3:4)04
```
When I navigate to the release and the shell installer link I get: https://github.com/axodotdev/cargo-dist/releases/tag/v1.0.0-rc.1 and then the file named dist-install.sh, resulting in the url: https://github.com/axodotdev/cargo-dist/releases/download/v1.0.0-rc.1/dist-installer.sh
I think that is the cause of the 404, as one is `dist-installer.sh`vs. `cargo-dist-installer.sh`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce `cargo dist init` and inspect the generated `release.yml`, comparing its installer URL with the `v1.0.0-rc.1` release assets and the failing GitHub Actions run. Done means the generated workflow references the available `dist-installer.sh` asset and the installation step no longer returns a 404.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, rust, shell
- Domain
- ci-cd, release
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100