awslabs / awslabs/ssosync

Where a user externalId does not match the user in Google Workspaces, improve the behavior

Closed
#358 0 comments 0 reactions 1 assignee Claimed by @ChrisPates View on GitHub
Dominant language
Go
Stars
666
Forks
213
Avg merge
1d 7h
Merged PRs (30d)
4

Description

**Is your feature request related to a problem? Please describe.**
Currently, if an ExternalId mismatches, a fallback branch checks for an email address match, if a match is found the user is updated with the relevant **ExternalId**.

A better behavior would be:
if an ExternalId mismatches, check for an email address match, if a match is found and the ExternalId is not set/set to nul, then update with the relevant **ExternalId**. This allows for matching existing locally created users, on first sync via ssosync. This is an important adoption route.

if an ExternalId mismatches, check for an email address match, if a match is found and the ExternalId has been set, then the existing user should be deleted and a new user created. When this situation occurs an Error should be logged.

Important to execute **remove** before **create**

**Describe alternatives you've considered**
Retaining the current behavior, and would be less disruptive but would in situations where and email address is being re-assigned or recycled (itself an anti-pattern), a different user could 'inherit' permission previously granted to the original user of the email address.

**Additional context**
Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.