awslabs / awslabs/python-deequ

[Pydeequ 1.0.1] pydeequ.checks.isContainedIn does not accept lambda assertion

Open
#88 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Jupyter Notebook
Stars
826
Forks
158
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
When running Pydeequ 1.0.1 the test generated by ConstraintSuggestionRunner include tests using the isContainedIn() function that fail during execution.

The cause is that the suggested tests include a lambda assertion which the python function does not accept as it takes 3 positional arguments but the suggested tests has 5

**To Reproduce**
Steps to reproduce the behavior:
1. Generate a test statement using a dataset that is incomplete, resulting in a suggestion for a test using isContainedIn() which uses a lambda:

- Example: 'value'is empty for more then 97% of the records:
- isContainedIn("value", [""], lambda x: x >= 0.97, "It should be above 0.97!")

2. Execute the test
3. Check output for error:
- TypeError: isContainedIn() takes 3 positional arguments but 5 were given

This issue has been reported before: https://github.com/awslabs/python-deequ/issues/65

The cause is that the current implementation of the isContainedIn was edited in https://github.com/awslabs/python-deequ/commit/30375bb8645728a539b7b2f6d2d85f89266ac047#diff-783716851e9837b9753e643de1f15e031f79bed4ef27e07ce67eeddc5a3fb2ee but the ConstraintSuggestionRunner was not updated to match the latest implementation.

It is unclear to me whether the suggested test is valid and the isContainedIn function needs to be extended or whether the change was made for a reason and thus the ConstraintSuggestionRunner should be adjusted to leave out the broken tests.

A previously made pull request does show how to revert the change: https://github.com/awslabs/python-deequ/pull/58

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.