awslabs / awslabs/python-deequ

hasNumberOfDistinctValues and hasHistogramValues require arguments that should be optional?

Closed
#81 3 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Jupyter Notebook
Stars
826
Forks
158
Avg merge
9d 22h
Merged PRs (30d)
3

Description

**Describe the bug**
The docs and Scala code for `hasNumberOfDistinctValues` and `hasHistogramValues` indicate that providing the `binningUdf, maxBins` parameters should be optional, but from the function definitions they seem to be required.

**To Reproduce**
Steps to reproduce the behavior:
1. Try to define a check with `check.hasNumberOfDistinctValues('column_name', lambda x: x == 6)`
2. See error: TypeError: hasNumberOfDistinctValues() missing 2 required positional arguments: 'binningUdf' and 'maxBins'

**Expected behavior**
I'd like to be able to call the hasNumberOfDistinctValues and hasHistogramValues without specifying a binning function and maxBins.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.