awslabs / awslabs/payload-offloading-java-common-lib-for-aws

Log s3 bucket name and object key for failed requests

Open
#16 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
34
Forks
17
PR merge metrics
No merged PRs in 30d

Description

When this library fails to retrieve an S3 object, it currently logs [an error message with the exception](https://github.com/awslabs/payload-offloading-java-common-lib-for-aws/blob/51021fcb6198c247045896cdc50bb4971eee47a4/src/main/java/software/amazon/payloadoffloading/S3Dao.java#L48). This exception contains a request id and an s3 extended request id, however it does not contain the name of the bucket and the object key that it was trying to retrieve.

Is it possible to add this context to the log and exception message? This data [is already logged](https://github.com/awslabs/payload-offloading-java-common-lib-for-aws/blob/51021fcb6198c247045896cdc50bb4971eee47a4/src/main/java/software/amazon/payloadoffloading/S3BackedPayloadStore.java#L47) in the success case but not in the failure case.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.