awslabs / awslabs/lorien

Is there something wrong with the to_list function?

Open
#2 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
42
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When commit the records to the database, we save the original records in the database and the records in log_file to the heap. After that, get the n best results and go to commit.
https://github.com/awslabs/lorien/blob/bcd39132e5f0738ee6f4685676ea8628cb4cea1b/lorien/tune/result.py#L239
What I understand is that -latency is stored in the heap. We should get the n largest values ​​in the heap, so I think we should use nlargest instead of nsmallest.
https://github.com/awslabs/lorien/blob/bcd39132e5f0738ee6f4685676ea8628cb4cea1b/lorien/dialect/tvm_dial/auto_scheduler_dial/result.py#L109
cc: @comaniac

Contributor guide

Open the contributing guide

Research direction

Read `lorien/tune/result.py` at line 239 and `lorien/dialect/tvm_dial/auto_scheduler_dial/result.py` at line 109, then trace how latency values are stored and how the best results are selected. Confirm whether the heap contains negative latency values and which results should be retained; done means the selection matches the intended ordering.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.