awslabs / awslabs/graphstorm

GSConfig should not affect log level setting

Open
#1,323 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
452
Forks
76
PR merge metrics
No merged PRs in 30d

Description

GSConfig is a wrapper object for GraphStorm but it includes code that enforces log level at the application level:

https://github.com/awslabs/graphstorm/blob/f0c38bbc2809dbbe2a956a93a31ba216fff13473/python/graphstorm/config/argument.py#L190-L198

The caller program should get to establish the logging level, using `logging.basicConfig(level=log_level, force=True)` overrides user intent, especially when the GraphStorm API is used.

Contributor guide

Open the contributing guide

Research direction

Start with python/graphstorm/config/argument.py at lines 190-198 and inspect how GSConfig configures logging. Verify that callers can establish their own level without GraphStorm overriding it; done means the wrapper no longer forces the application-wide log level.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
developer-experience
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.