awslabs / awslabs/git-secrets

Would it be possible for install to use full path to git-secrets?

Open
#183 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
13.4k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/awslabs/git-secrets/blob/master/git-secrets#L206

There at least a few IDEs/editors (JetBrains RubyMine, VS Code) that choke on the git hooks that get installed. If you try to commit from within the IDE's git interface, it blows up and says:
![image](https://user-images.githubusercontent.com/1079/96205996-f0a59980-0f35-11eb-98d9-5273838bd8cf.png)

This is because the IDE runs `git` with some sort of weird setting for `$PATH`. For example, RubyMine seems to run it's git executable with the following `$PATH`: `/usr/local/Cellar/git/2.28.0/libexec/git-core:/usr/bin:/bin:/usr/sbin:/sbin` while `git-secrets` is at `/usr/local/bin/git-secrets` (`brew install git-secrets`)...

Would it be possible or make sense for the install script to use the absolute path itself?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.