awslabs / awslabs/git-secrets

Successful exit code if a regex is invalid

Open
#151 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
13.4k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

If an invalid regex pattern is added to config, e.g. "(" not escaped, git-secrets exits with exit code 0. Because the regex is invalid, it does not scan anything. This is not good for integrating it into a CI/CD-pipeline. As there is an error, shouldn't git-secrets exit with another exit code?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.