awslabs / awslabs/eks-perf-tests

Updating Karpenter version to v0.10.0 affecting repo

Open
#301 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
72
Forks
50
PR merge metrics
No merged PRs in 30d

Description

Running make dev or make apply command cannot build the repo with following error

88665a4364f7:substrate sushima$ make dev
controller-gen \
		object:headerFile="hack/boilerplate.go.txt" \
		paths="./pkg/..."
hack/boilerplate.sh
go mod tidy
go mod download
go vet ./...
go fmt ./...
golangci-lint run
pkg/controller/substrate/cluster/config.go:30:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^
pkg/utils/kubectl/apply.go:24:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^
pkg/utils/kubectl/client.go:19:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^
make: *** [verify] Error 1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with pkg/controller/substrate/cluster/config.go, pkg/utils/kubectl/apply.go, and pkg/utils/kubectl/client.go, then run make dev or make apply to reproduce the reported staticcheck failures. Review the ioutil usages in those files and verify that the build and verification command complete without SA1019 errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.