awslabs / awslabs/aws-solutions-constructs

Replace | any with Partial<T> for type checking across all constructs

Open
#250 11 comments 0 reactions 1 assignee View on GitHub

@biffgaut is already working on this.

Since Jul 6, 2021.

External Dependency
Dominant language
TypeScript
Stars
1.4k
Forks
269
Avg merge
5h 18m
Merged PRs (30d)
5

Description

Could Partial<cloudfront.DistributionProps> not be used instead?

Originally posted by @naseemkullah in https://github.com/awslabs/aws-solutions-constructs/issues/247#issuecomment-869812304

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.