awslabs / awslabs/aws-lambda-redshift-loader

Missing callback in createS3EventSource when notification configuration already exists

Open
#211 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
595
Forks
161
PR merge metrics
No merged PRs in 30d

Description

common.js/createS3EventSource method:
There is a missing callback in case of notification configuration already exists.

At line 574 of common.js
Could you please change the code from:

if (!configAlreadyExists){
logger.info('Creating notification configuration');

to:

if (configAlreadyExists) {
callback();
} else {
logger.info('Creating notification configuration');

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.