awslabs / awslabs/aws-lambda-redshift-loader
Missing callback in createS3EventSource when notification configuration already exists
Open
- Dominant language
- JavaScript
- Stars
- 595
- Forks
- 161
- PR merge metrics
- No merged PRs in 30d
Description
common.js/createS3EventSource method:
There is a missing callback in case of notification configuration already exists.
At line 574 of common.js
Could you please change the code from:
if (!configAlreadyExists){
logger.info('Creating notification configuration');
to:
if (configAlreadyExists) {
callback();
} else {
logger.info('Creating notification configuration');
Contributor guide
Assessment
This issue has not been assessed yet.