awslabs / awslabs/aws-embedded-metrics-python

Is it intended that new copies of MetricContext retain error details

Open
#74 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Python
Stars
231
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Am using and extending the `MetricsLogger` and discovered that error details also get copied to fresh `MetricsContext` objects. Is it the intended behavior for all properties, including error details to be carried forward on new and copied `MetricsContext` objects?

https://github.com/awslabs/aws-embedded-metrics-python/blob/master/aws_embedded_metrics/logger/metrics_logger.py#L104
https://github.com/awslabs/aws-embedded-metrics-python/blob/master/aws_embedded_metrics/logger/metrics_context.py#L127

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.