awslabs / awslabs/aws-deployment-framework

adf-accounts: Should it create new OUs if they don't exists?

Open
#263 1 comment 3 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
Python
Stars
699
Forks
235
Avg merge
20h 53m
Merged PRs (30d)
7

Description

ADF Version: 3.0.1
`
- account_full_name: "some-random-account"
--
  | organizational_unit_path: /existing/new-ou
  | email: some-random-account@accounts.skyscnr.com
  | allow_billing: True
  | delete_default_vpc: False
  | alias: some-random-account
  | tags:
  | - managed_by_adf: True

`

In this kind of example, when adding a new account via adf-accounts/.yml

It will fail with a ValueError because it can't find the OU.
[File Here](https://github.com/awslabs/aws-deployment-framework/blob/master/src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py#L291)

Do we think this should create the relevant OU if it doesn't exist?
What's the thoughts on that?
There's pros:
- allows for smoother creation of OUs and moving accounts "as code"
- keeps everything in the same process

Cons:
- Could hide errors if there's a typo in an OU name

Contributor guide

Open the contributing guide

Research direction

Start with the adf-accounts configuration example in the issue and inspect src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/organizations.py at line 291, where the missing OU causes a ValueError. Reproduce the behavior with an organizational_unit_path containing a new OU, then determine whether the intended result is to create it or reject the configuration. Done should include an agreed behavior and its implementation or documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, python
Domain
cloud, infrastructure
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.