awslabs / awslabs/aws-codedeploy-plugin

Allow Symlinks in Subdirectory

Open
#56 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
156
Forks
130
PR merge metrics
No merged PRs in 30d

Description

Inside of this:
private FilePath getSourceDirectory(FilePath basePath) throws IOException, InterruptedException {
String subdirectory = StringUtils.trimToEmpty(this.subdirectory);
if (!subdirectory.isEmpty() && !subdirectory.startsWith("/")) {
subdirectory = "/" + subdirectory;
}
FilePath sourcePath = basePath.withSuffix(subdirectory).absolutize();
if (!sourcePath.isDirectory() || !isSubDirectory(basePath, sourcePath)) {
throw new IllegalArgumentException("Provided path (resolved as '" + sourcePath
+"') is not a subdirectory of the workspace (resolved as '" + basePath + "')");
}
return sourcePath;
}

Can we get another clause that will allow for symlinks to also not throw the illegal argument?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.