awslabs / awslabs/aws-codebuild-jenkins-plugin
Inconsistant Jenkins target version
- Dominant language
- Java
- Stars
- 156
- Forks
- 130
- PR merge metrics
- No merged PRs in 30d
Description
aws-codebuild-jenkins-plugin targets Jenkins 2.60.3, but its dependency targets Jenkins > 2.60.3.
Example: https://github.com/awslabs/aws-codebuild-jenkins-plugin/pull/128
You bumped script-security 1.56 to 1.75, but script-security-1.75 targets Jenkins-2.176.4: https://github.com/jenkinsci/script-security-plugin/blob/script-security-1.75/pom.xml @leoherran-aws
This results `mvn hpi:run` failed with:
```
Jul 03, 2022 4:03:06 AM jenkins.InitReactorRunner$1 onTaskFailed
SEVERE: Failed Loading plugin Script Security Plugin v1.75 (script-security)
java.io.IOException: Script Security Plugin v1.75 failed to load.
- You must update Jenkins from v2.60.3 to v2.176.4 or later to run this plugin.
at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:626)
at hudson.PluginManager$2$1$1.run(PluginManager.java:516)
at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
at jenkins.model.Jenkins$7.runTask(Jenkins.java:1090)
at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
Same to other dependencies. Attached full error log: [aws-codebuild-startup-failure.txt](https://github.com/awslabs/aws-codebuild-jenkins-plugin/files/9034063/aws-codebuild-startup-failure.txt)
You should upgrade also target Jenkins version.
It makes sense to introduce Jenkins plugin BOM: https://www.jenkins.io/doc/developer/plugin-development/dependency-management/#jenkins-plugin-bom
Contributor guide
Research direction
Start with the plugin's Maven dependency declarations and compare its Jenkins target with the versions required by script-security and the other dependencies. Review the Jenkins plugin BOM guidance, then run `mvn hpi:run`; done means the plugin dependencies resolve against a compatible Jenkins target without the reported startup failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, java
- Domain
- build-system, devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100