awslabs / awslabs/amazon-kinesis-client-python

review return type in messages.Record.binary_data

Open
#82 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
377
Forks
228
PR merge metrics
No merged PRs in 30d

Description

From running the sample word app on python 3.6.5, the data that comes into the process_record method has the type 'bytes'. That value comes from the binary_data inside the Record class. The return type for that property is str but it should probably be updated to bytes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.