awslabs / awslabs/amazon-dynamodb-lock-client

Closing the client logs an exception

Open
#4 0 comments 1 reaction 0 assignees View on GitHub
question
Dominant language
Java
Stars
521
Forks
92
PR merge metrics
No merged PRs in 30d

Description

AmazonDynamoDBLockClient:955 logger.info("Heartbeat thread recieved interrupt, exiting run() (possibly exiting thread)", e);

Prints
[dynamodb-lock-client-1] INFO com.amazonaws.services.dynamodbv2.AmazonDynamoDBLockClient - Heartbeat thread recieved interrupt, exiting run() (possibly exiting thread)
java.lang.InterruptedException: sleep interrupted
at java.lang.Thread.sleep(Native Method)
at com.amazonaws.services.dynamodbv2.AmazonDynamoDBLockClient.run(AmazonDynamoDBLockClient.java:955)
at java.lang.Thread.run(Thread.java:748)

Which kind of looks like an error occurred.

In my opinion it should
a) Log as debug
b) Not log the stack trace

Contributor guide

Open the contributing guide

Research direction

Start at AmazonDynamoDBLockClient.java around line 955 and inspect the heartbeat thread's interrupt logging path. Compare the current output with the requested behavior: the expected interrupt should not appear as an error or include a stack trace; verify the resulting log output.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.