awslabs / awslabs/agentcore-samples

Entra ID integration security fixes

Open
#843 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
3.4k
Forks
1.3k
Avg merge
1d 22h
Merged PRs (30d)
30

Description

Address following issues with Entra Examples

Step_by_Step_Entra_ID_for_Inbound_Auth.ipynb
- Uses client device flow
- Does not provide instructions on how to get key information like tenant Id, client ID, Client Secret.
- uses local build for AgentCore Runtime. Needs local Docker installation

Step_by_Step_Entra_ID_with_AgentCore_Gateway.ipynb
- Duplicate images in Step 3.5
- Does not provide instructions on how to get key information like tenant Id, client ID, Client Secret.
- Wrong image referenced in “6. Grant admin consent to use the APIs”

Microsoft_EntraID_and_3LO_Outbound_for_Tools.ipynb
- Duplicate pip installs in Step 2
- Entra ID UI for adding redirect URL and selecting tokens to issue has changed,
- uses local build for AgentCore Runtime. Needs local Docker installation
- Missing Session Binding Code at the end of “Step 4 - Put it all together as an AgentCore Runtime Agent”
- Uses python-jwt which is not commonly sued
- Images does nto explain how to access OneNote and valdiate that a new Note is creatred,

Contributor guide

Open the contributing guide

Research direction

Start with Step_by_Step_Entra_ID_for_Inbound_Auth.ipynb, Step_by_Step_Entra_ID_with_AgentCore_Gateway.ipynb, and Microsoft_EntraID_and_3LO_Outbound_for_Tools.ipynb, reviewing each listed step and its current Entra ID instructions. Verify the notebooks use correct images, setup guidance, dependencies, runtime requirements, and session-binding material, then validate that the documented OneNote flow can be followed successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, jupyter-notebook, python
Domain
authentication, documentation, security
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.