aws / aws/sagemaker-training-toolkit
Loosen or update protobuf pinned version
- Dominant language
- Python
- Stars
- 530
- Forks
- 140
- Avg merge
- 1h 12m
- Merged PRs (30d)
- 2
Description
**Describe the feature you'd like**
`protobuf` is currently pinned to `"protobuf>=3.9.2,<=3.20.3"` in https://github.com/aws/sagemaker-training-toolkit/blob/859d0198d3979f59fc22a24c0b6cf4860e241045/setup.py#L43C5-L43C31. This prevents installation of other packages that require a higher protobuf version, e.g. http://github.com/onnx/onnx/releases/tag/v1.18.0 which requires `>=4.25.1`.
**How would this feature be used? Please describe.**
A clear and concise description of the use case for this feature. Please provide an example, if possible.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
Contributor guide
Research direction
Review the protobuf requirement in setup.py at the referenced line and compare it with the compatibility need described for ONNX v1.18.0. Determine an appropriate updated constraint, then verify that the package metadata allows installation alongside packages requiring protobuf >=4.25.1.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100