aws / aws/sagemaker-spark

Un-necessary arguments required for SageMakerEstimator when Endpoint creation is not required

Open
#46 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Scala
Stars
301
Forks
129
PR merge metrics
No merged PRs in 30d

Description

Please fill out the form below.

### System Information
- **Spark or PySpark**: Spark
- **SDK Version**: Master
- **Spark Version**: All
- **Algorithm (e.g. KMeans)**: All

### Describe the problem

When creating SageMakerEstimator class , if the EndpointCreationPolicy is not required or set to DO_NOT_CREATE , we should not be specifying arguments like :
requestRowSerializer
responseRowDeserializer
modelEnvironmentVariables

Since they do not have any defaults

### Minimal repo / logs
This is a design fix request so that user does not have to provide information to the constructor when there is no requirement for creation of endpoint

- **Exact command to reproduce**:
NA

Contributor guide

Open the contributing guide

Research direction

Locate the SageMakerEstimator constructor and the EndpointCreationPolicy handling, then inspect any related tests. Determine how requestRowSerializer, responseRowDeserializer, and modelEnvironmentVariables are validated for DO_NOT_CREATE; done means those arguments are optional when no endpoint is created while remaining required when endpoint creation needs them, with coverage for both paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, scala, spark
Domain
backend-api-design, machine-learning
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.