aws / aws/sagemaker-hyperpod-cli
Inconsistent field names in helm_chart/HyperPodHelmChart/values.yaml
- Dominant language
- Python
- Stars
- 41
- Forks
- 95
- Avg merge
- 23h 5m
- Merged PRs (30d)
- 8
Description
In the helm [values.yaml](https://github.com/aws/sagemaker-hyperpod-cli/blob/main/helm_chart/HyperPodHelmChart/values.yaml) file, there is this section:
```
trainingOperators:
enabled: true
inferenceOperators:
enabled: false
```
The field name "trainingOperators", "inferenceOperators" are inconsistent with actual sub-chart names.
It is being a pitfall for customers, because even if customers try to override parameters of sub-charts under "trainingOperators" and "inferenceOperators", it doesn't take effect, because of the mismatch.
Please see the [Chart.yaml](https://github.com/aws/sagemaker-hyperpod-cli/blob/main/helm_chart/HyperPodHelmChart/Chart.yaml) file as well.
Only training-operator and inference-operator are inconsistent.
```
- name: training-operators
version: "0.1.0"
repository: "file://charts/training-operators"
condition: trainingOperators.enabled
```
```
- name: hyperpod-inference-operator
version: "0.1.0"
repository: "file://charts/inference-operator"
condition: inferenceOperators.enabled
```
Please fix this inconsistency.
Contributor guide
Assessment
This issue has not been assessed yet.