aws / aws/sagemaker-distribution

s3fs unit test broken before commit tagged by 2025.2.0

Open
#559 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
154
Forks
120
Avg merge
5d 4h
Merged PRs (30d)
27

Description

s3fs is one of our marquee dependency introduced in 2.3.0, its unit test keep failing due to error:
```
s3 =

def test_info(s3):
s3.touch(a)
s3.touch(b)
info = s3.info(a)
linfo = s3.ls(a, detail=True)[0]
assert abs(info.pop("LastModified") - linfo.pop("LastModified")).seconds < 1
info.pop("VersionId")
info.pop("ContentType")
linfo.pop("Key")
linfo.pop("Size")
> assert info == linfo
E assert {'ETag': '"d4...size': 0, ...} == {'ChecksumAlg.../test/a', ...}
E
E Omitting 5 identical items, use -vv to show
E Right contains 1 more item:
E {'ChecksumAlgorithm': ['CRC32']}
E Use -v to get more diff

test_s3fs.py:271: AssertionError
```
The failure is due to a new change introduced since:
https://github.com/fsspec/s3fs/blame/2025.2.0/s3fs/tests/test_s3fs.py#L272

There is no actual functionality issue, but we cannot fix this unit test failure until a new major version bump to upgrade s3fs version.

We may also consider not follow semiver rule for `s3fs`, as its version represents timestamp only.

Contributor guide

Open the contributing guide

Research direction

Start with the upstream s3fs test_s3fs.py around line 271 and inspect the project's pinned s3fs version and semver policy. Reproduce the ChecksumAlgorithm mismatch, then determine whether the next major-version upgrade resolves it or whether the versioning policy needs an explicit decision; done means the test passes without masking a real functionality issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.