aws / aws/s2n-netbench

CI: GHA that doesn't support merge queues

Open
#43 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
9
Forks
7
PR merge metrics
No merged PRs in 30d

Description

### Security issue notifications

If you discover a potential security issue in s2n-netbench we ask that you notify
AWS Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.

### Problem:

The [commit-status-updater](https://github.com/ouzi-dev/commit-status-updater) checks the event type and fails if it's not [push or pull_request](https://github.com/ouzi-dev/commit-status-updater/blob/master/src/utils.ts#L5)

### Solution:

Short term, the report check will no longer be required to pass. Publishing still occurs successfully, the issue is that with merge queues in use, no PRs will ever get past this check.

Longer term: find another GHA or log an issue/PR against ouzi-dev.

### Requirements / Acceptance Criteria:

CI should pass regardless of event type: push or merge_group

[//]: # (NOTE: If you believe this might be a security issue, please email aws-security@amazon.com instead of creating a GitHub issue. For more details, see the AWS Vulnerability Reporting Guide: https://aws.amazon.com/security/vulnerability-reporting/ )

Contributor guide

Open the contributing guide

Research direction

Inspect the GitHub Actions workflow that invokes commit-status-updater and its event handling; the issue links to src/utils.ts in that action. Check CI behavior for push and merge_group events, and verify that the report check no longer blocks either event while publishing still succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.