aws / aws/s2n-netbench

[orchestrator]: reduce dead_code warnings

Open
#38 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
9
Forks
7
PR merge metrics
No merged PRs in 30d

Description

### Problem:
https://github.com/aws/s2n-netbench/pull/28#discussion_r1600756779

There is currently a bunch of `#[allow(dead_code)]` since we compile two [`bin`s](https://github.com/aws/s2n-netbench/blob/main/netbench-orchestrator/Cargo.toml#L11-L17) and this results in some code not being used.

Contributor guide

Open the contributing guide

Research direction

Start with netbench-orchestrator/Cargo.toml and the two bin targets linked in the issue, then read the referenced pull-request discussion. Inventory the #[allow(dead_code)] cases and determine which code each binary uses. Done means the orchestrator builds both binaries without unnecessary dead_code warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.