aws / aws/jsii

Go: submodules with same name are not resolving imports correctly in pacmak

Open
#4,985 0 comments 0 reactions 0 assignees View on GitHub
needs-triage p1
Dominant language
TypeScript
Stars
2.9k
Forks
267
Avg merge
1d 25m
Merged PRs (30d)
14

Description

### Describe the bug

If I have multiple submodules that share the same last part, e.g.

```
asm.service
asm.interfaces.service
asm.mixins.service
```

And the packages depend on each other, e.g. `asm.service` is using `asm.interfaces.service`, then the bindings generated by pacmak resolve these imports incorrectly.

Specifically inside `asm.service`, when pacmak encounters a type from `asm.interfaces.service`, it thinks that the type is form the same package and doesn't prefix the import. It does however correctly add the require statement.

### Regression Issue

- [ ] Select this option if this issue appears to be a regression.

### Expected Behavior

Bindings should correctly import from the package.

### Current Behavior

Compile error.

### Reproduction Steps

see above

### Possible Solution

_No response_

### Additional Information/Context

_No response_

### SDK version used

any

### Environment details (OS name and version, etc.)

any

Contributor guide

Open the contributing guide

Research direction

Start at pacmak's Go binding generation and reproduce the case with asm.service, asm.interfaces.service, and asm.mixins.service, where the packages depend on one another. Inspect how imports are resolved when submodules share the same final component, then verify that generated bindings compile and reference the correct package.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.