aws / aws/graph-explorer

Move default connection generation in to server endpoint

Open
#507 0 comments 0 reactions 1 assignee Claimed by @kmcginnes View on GitHub
fundamental infrastructure reliability usability
Dominant language
TypeScript
Stars
481
Forks
108
Avg merge
6d 8h
Merged PRs (30d)
5

Description

Currently, the default connection is configured in a myriad of ways.

- Environment values set at docker run time
- Environment values set in `.env` file
- A `config.json` file that sets environment values

Then a Bash script interprets all of these options and generates a `defaultConnection.json` file. That file is then served as a static file by the `/defaultConnection` endpoint in Express.

Instead, I propose simplifying the approach a bit. The `/defaultConnection` endpoint can read the environment values, validate them, and generate the proper JSON object to send to the client. This removes complex and brittle Bash code to parse and manipulate JSON files and provides an easier path to testing the logic. It also allows for better defaults and fallback values.

## Related issues

- Similar idea #1265

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.