aws / aws/graph-explorer

Enable remaining disabled oxlint rules

Open
#1,753 0 comments 0 reactions 1 assignee Claimed by @kmcginnes View on GitHub
reliability tech debt
Dominant language
TypeScript
Stars
481
Forks
108
Avg merge
6d 8h
Merged PRs (30d)
5

Description

Several oxlint rules are currently disabled because they have violations that need code fixes. This issue tracks enabling them.

## Rules to enable

### `typescript/unbound-method` (65 violations)
Flags passing class methods as callbacks without binding. Many are likely false positives (Jotai setters, React Query methods that don't use `this`), but some could be real bugs. Needs triage.

### `typescript/no-floating-promises` (28 violations)
Requires all Promises to be awaited, returned, or explicitly voided. High-value rule — unhandled rejections are a common source of silent failures. Audit each violation: add `void` for intentional fire-and-forget, `await` for the rest.

### `jsx-a11y/click-events-have-key-events` + `jsx-a11y/no-static-element-interactions` (1 violation)
`ConnectionRow.tsx` has a `

` without keyboard support. Fix: use a `` or add `role="button"` + `onKeyDown` handler.

### `jsx-a11y/mouse-events-have-key-events` (2 violations)
`TabularRow.tsx` has `onMouseOver`/`onMouseOut` without `onFocus`/`onBlur`. Fix: add focus/blur handlers for keyboard users, or accept hover highlighting as visual-only and add inline disables.

---

> [!IMPORTANT]
> If you are interested in working on this issue, please leave a comment.

> [!TIP]
> Please use a 👍 reaction to provide a +1/vote. This helps the community and maintainers prioritize this request.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.