aws / aws/graph-explorer

Remove mergedConfigurationSelector and legacy schema-style coupling

Open
#1,729 0 comments 0 reactions 0 assignees View on GitHub
enhancement performance schema tech debt
Dominant language
TypeScript
Stars
481
Forks
108
Avg merge
8d 9h
Merged PRs (30d)
7

Description

## Description

Once all consumers have been migrated (#1726, #1727, #1728), the legacy merge system can be deleted.

## Preferred Solution

- Delete `mergedConfigurationSelector` and `mergeConfiguration()`
- Delete `RawConfiguration.schema` (the config-provided schema is defunct)
- Remove the `& VertexPreferencesStorageModel` intersection from `VertexTypeConfig`
- Remove the `& EdgePreferencesStorageModel` intersection from `EdgeTypeConfig`
- Delete any helper functions that only existed to support the 3-way merge (e.g., `patchToRemoveDisplayLabel`)
- Update or remove tests that test the old merge behavior

## Related Issues

- Part of #1677
- Depends on #1726
- Depends on #1727
- Depends on #1728

---

> [!IMPORTANT]
> If you are interested in working on this issue, please leave a comment.

> [!TIP]
> Please use a 👍 reaction to provide a +1/vote. This helps the community and maintainers prioritize this request.

Contributor guide

Open the contributing guide

Research direction

Search for mergedConfigurationSelector, mergeConfiguration(), RawConfiguration.schema, the VertexTypeConfig and EdgeTypeConfig intersections, and patchToRemoveDisplayLabel. Review dependent issues #1726, #1727, and #1728 before removing the legacy merge support, then update or remove tests covering the old behavior. Done means the listed legacy APIs, schema coupling, helper functions, and obsolete tests are gone and the test suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.