aws / aws/graph-explorer

Decouple ServerLoggerConnector from connection

Open
#1,623 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
481
Forks
108
Avg merge
8d 9h
Merged PRs (30d)
7

Description

## Parent PRD

- Parent #1618

## What to build

Update `ServerLoggerConnector` to use the `apiBase` constant directly instead of receiving a connection URL in its constructor. Replace `createLoggerFromConnection` with a connection-independent factory that always creates a `ServerLoggerConnector`. Logging to the server works even before a connection is configured.

**Type: HITL** — requires review before completion.

## Acceptance criteria

- [ ] `ServerLoggerConnector` constructor takes no arguments, uses `apiBase` internally
- [ ] `createLoggerFromConnection` is replaced with a simpler factory (no connection dependency)
- [ ] Server logging works before any connection is configured
- [ ] Tests verify logs are sent to `${apiBase}logger`
- [ ] Tests verify the logger works without a connection

## Blocked by

- Blocked by #1621

## User stories addressed

- User story 11

Contributor guide

Open the contributing guide

Research direction

After blocked issue #1621 is resolved, locate ServerLoggerConnector, createLoggerFromConnection, and the apiBase constant. Read the existing logger tests first, then update coverage to verify requests target `${apiBase}logger` and succeed before a connection is configured.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.